-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to schedule all reports, even for once #3840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good to me 👍 The PR is quite detailed, thanks for that. Just a small note for the next time: please remove the boilerplate text (in the "Issue link" section, either fill it in or remove the section entirely)
There's still an issue with the tests. Apparently a |
Yes, this will be fixed probably when the Pr of JP is merged with main, also the test fix :) |
Co-authored-by: Peter-Paul van Gemerden <[email protected]>
Co-authored-by: Peter-Paul van Gemerden <[email protected]>
We continue with implementation of time widget as per: |
…ture/report_creations_are_scheduled
…invws/nl-kat-coordination into feature/report_creations_are_scheduled
…invws/nl-kat-coordination into feature/report_creations_are_scheduled
…ture/report_creations_are_scheduled
…ture/report_creations_are_scheduled
…invws/nl-kat-coordination into feature/report_creations_are_scheduled
…invws/nl-kat-coordination into feature/report_creations_are_scheduled
During QA of the earlier bugs a new bug was identified. On the last page of the onboarding an error is thrown. After debugging this session with @Rieven we came to the conclusion that the scheduler takes a bit more time to be ready compared to before. (aka I click through the onboarding too fast). Waiting 2 minutes during the pre-last step of the onboarding doesn't throw this error. |
Fixed in 6eebbff |
Quality Gate failedFailed conditions |
Checklist for QA:
What works:Onboarding now works, the last step of the onboarding now loads for ~30 seconds before it continues to the last step. Not ideal for the user, but it prevents the user from receiving the error. This will be fixed by some future updates in the scheduler (hopefully v1.19). What doesn't work:n/a Bug or feature?:n/a |
Changes
deadline_at
(start date and time)auto_calculate_deadline
attribute to Scheduler #3869 to not reschedule task when choosing once.Issue link
#3753
Closes #3753
Demo
QA notes
You will need to restart the report runner.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.